Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Alpha NP production fix #4519

Closed
wzdev-ci opened this issue Oct 16, 2016 · 11 comments
Closed

Alpha NP production fix #4519

wzdev-ci opened this issue Oct 16, 2016 · 11 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_closed type_patch (an actual patch, not a request for one) | by Berserk Cyborg


Alpha campaign missions sub1_5 and later were somewhat broken in the aspect that the New Paradigm could not build/produce certain cyborgs, tanks, or structures. This was simply due to a few missing research stats.

I tested each affected level and there were no adverse effects from my changes, so I don't think I broke anything. This should at least make those levels somewhat more difficult now.

branch: https://github.com/KJeff01/warzone2100/tree/CampaignFixes


Issue migrated from trac:4519 at 2022-04-16 12:37:45 -0700

@wzdev-ci
Copy link
Contributor Author

alfred007 commented


Also the Collective in Beta campaign.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


This took longer than I expected (since almost all campaign missions were affected), but I was able to stop all instances of #4459. Also prevents #4479 happening as well. I did a lot of testing myself, but if anyone wants to do a quick run through to make sure I did not forget something or break anything that would be much appreciated.

Because of #4459 I tweaked some of the units that the enemy AI may produce and some levels build trucks to build defenses. Also some levels have their factory production times lowered if appropriate since waiting anywhere from 3 to 15 minutes seems under-powered.

So for 3.2.2 or whatever the campaign should not feel as broken as before.

EDIT: Removed unnecessary changes in cam1c and cam1ca

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 7, 2016

NoQ commented


Woohoo, thanks for the huge patch!

This should at least make those levels somewhat more difficult now.

Before i forget: The goal is to maintain campaign as close to the original campaign as possible. Many people complain that the campaign has become more difficult (eg. ripple rocket accuracy has changed), so while i wholeheartedly agree that difficult campaign is fun, we cannot afford modifying it for simply increasing difficulty.
Because it's hard to find/run the original game nowadays (legally), we try to get away with comparing to the latest version we're able to run, unless more inconsistencies pointed out explicitly.

cam1c.js

I do not quite understand this change, what is the reason to enable the central factory by timer rather than by player's reaching a zone?

cam1ca.js

Whoops nice.

/minDroid/truck/

Also typo, thanks!

RESEARCHSTAT changes

Hmm. The recent changes in sync / anti-cheat checks might have been the root cause for that; earlier, we just didn't check that stuff needs to be researched, and now AI scripts are covered by this check, maybe campaign scripts as well.
It might be that we could just make an exception for the campaign in this rule, instead of massive changes in wzscript files.
My hypothesis may be verified against v3.1.0 probably (which didn't have new checks yet).

ZNULLSENSOR

Do these tanks see anything with this sensor?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 7, 2016

Berserk Cyborg commented


By difficulty I meant that the enemy can produce units since all wzscript levels can not produce anything in 3.2.1 anyway. And using some units the enemy could use, but were commented out in the .vlo files.

I used the ZNullSensor(which the enemies can see with) because gamma enemy units were considered 'illegal droids' with the navGunSensor.

Then again, If its sync/anti-cheat checks then it would certainly be a better fix. I guess I made a potential campaign mod then, lol.

@wzdev-ci
Copy link
Contributor Author

NoQ commented


I guess I made a potential campaign mod then, lol.

Well, the result must be identical, ideally, anyway. It's just that huge and possibly-buggy (i trust you but who knows where a mistake may dig into) changes in campaign scripts that will be thrown away anyway during js rewrite (which i'm damn happy to see revived btw) might be not quite worth the effort compared to making a single-line-of-code exception. So i think this needs an opinion

I used the ZNullSensor(which the enemies can see with) because gamma enemy units were considered 'illegal droids' with the navGunSensor.

You can switch to another player through cheat=>ctrl+o, and see if these units are actually seeing anything. If that's tested, i'm ok with the change; not expert in sensors though.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 3, 2016

Berserk Cyborg commented


Ticket can be closed. Obsoleted by campaign script conversions I am doing now.

@wzdev-ci
Copy link
Contributor Author

Cyp changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed resolution from `` to closed

@wzdev-ci
Copy link
Contributor Author

Cyp changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Cyp changed blockedby which not transferred by tractive

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant