Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

[RFC]Preliminary Vulkan support #4523

Closed
wzdev-ci opened this issue Nov 5, 2016 · 7 comments
Closed

[RFC]Preliminary Vulkan support #4523

wzdev-ci opened this issue Nov 5, 2016 · 7 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Nov 5, 2016

resolution_closed type_patch (an actual patch, not a request for one) | by Vincent


This patch adds a Vulkan backend to WZ2100.
It's based on commits removing fixed function calls and commits adding per pixel lighting so it won't apply on master.
I'm posting it here to gather comments on the implementation since the code is very invasive.

I used auto in a lot of place, I think I will turn them into proper type in a final patch ; Almost Always Auto codestyle is very nice when creating a new abstraction or refactoring code but it's quite hard to read without IDE support.
Vulkan is a very verbose API and even if I throwed in vulkan HPP and generic lambdas at it it's still 1500 of code. And there's no mipmaping support of shader cache functionnalities at the moment.


Issue migrated from trac:4523 at 2022-04-16 12:38:00 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 5, 2016

Vincent uploaded file 0001-Use-vulkan-hpp.patch (309.5 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 5, 2016

Per changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 5, 2016

Per changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Nov 5, 2016

Per commented


Very impressive.

Sorry I've been late merging stuff, been held up on an unrelated bug fix and general lack of time.

Is there any chance we could use one set of shaders, with some #ifdefs to distinguish between shaders for OpenGL 3.2 core profile and for Vulkan?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2019

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2019

Berserk Cyborg changed resolution from `` to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 5, 2019

Berserk Cyborg commented


Closing since Warzone2100/warzone2100#489 takes its place.

@wzdev-ci wzdev-ci closed this as completed Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant