Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Object transfer lag bug #4554

Closed
wzdev-ci opened this issue Feb 16, 2017 · 8 comments
Closed

Object transfer lag bug #4554

wzdev-ci opened this issue Feb 16, 2017 · 8 comments
Labels
closed component: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Berserk Cyborg

I have been encountering an issue that I was finally able to reproduce at a consistent rate now. What happens is that if a droid is transferred with either a Nexus Link or donateObject(), then the log file will assert with something that looks like this:

CHECK_DROID: More body points (2187) than original body points (540).

This will then produce more and more lag (with a rapidly growing log file) with each successive bad transfer.

I discovered is that if the droid is taken from an enemy player with superior research (defense upgrades?), then this issue happens.

Issue migrated from trac:4554 at 2022-04-16 12:40:14 -0700
@wzdev-ci
Copy link
Contributor Author

Per changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Per changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Per commented

Interesting. I wonder what the correct solution is - to reduce the body points to the research level of the receiving player, or to remove the sanity check against this, allowing you to have superior units received by other players...

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented

Keeping the superior droid would be more 'realistic' since they have the new research applied to them anyway... Though if there is a way that object transfers can be used to cheat somehow, then just reduce to the research levels of the receiving player just to be safe.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2017

Cyp <cyp@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2017

Cyp <cyp@...> changed owner from `` to Cyp <cyp@wz2100.net>

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2017

Cyp <cyp@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2017

Cyp <cyp@...> commented

In Warzone2100/warzone2100@d0934ff:

#CommitTicketReference repository="" revision="d0934ff3adb980f4c3c67d3c6c4a3572af0a6890"
Rescale body points if players have different armour levels, when transferring units.

Fixes #4554.

@wzdev-ci wzdev-ci closed this as completed Apr 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci