Fix allocation of players, spelling corrections and fewer LOC #4612
Comments
Forgon uploaded file patch file created with |
Per Inge Mathisen <per.mathisen@...> commented In Warzone2100/warzone2100@d0dd6cf:
|
Forgon commented What about all the rest of the patch? |
Per changed blocking which not transferred by tractive |
Per changed blockedby which not transferred by tractive |
Per commented I need some more time to look at those. Just took the easy things first. Thanks for the patch, BTW. |
Per commented I'm a bit confused by the "ensures game does not start in DEBUG mode" part of the patch, because I've never seen this problem. How and when does this happen? |
Berserk Cyborg commented Replying to Warzone2100/old-trac-import#4612 (comment:4):
|
Per Inge Mathisen <per.mathisen@...> committed [3] In Warzone2100/warzone2100@3a871f2:
|
Per Inge Mathisen <per.mathisen@...> changed status from |
Per Inge Mathisen <per.mathisen@...> changed owner from `` to |
Per Inge Mathisen <per.mathisen@...> changed resolution from `` to |
Per Inge Mathisen <per.mathisen@...> committed [4] In Warzone2100/warzone2100@4b91398:
|
resolution_fixed
type_patch (an actual patch, not a request for one)
| by ForgonThe function 'processDebugMappings()' in './src/keymap.cpp' activates the debug mode if Player 0 is
not allocated at its invocation. This lead to two errors in the bizarre code responsible for loading games, both of which are now patched:
Other changes:
'keyClearMappings' in './src/keymap.cpp' was a useless function and called both before and during the start of 'keyInitMappings' in several instances (see './src/init.cpp', './src/keyedit.cpp', './src/keymap.cpp')
chat messages in campaigns and tutorials now display 'Commander' as player name (see './src/multiplay.cpp')
no more empty line at the start of logfiles (see './lib/framework/debug.cpp')
no more two consecutive slashes in pathnames (hopefully) (see './lib/framework/frame.cpp' and './src/levels.cpp')
removed unused and empty functions 'StartTextInput()' and 'StopTextInput' (see './lib/qtgame/main_qt.cpp')
fixed typos: allign -> align, allignment -> alignment, blu box -> blue box, bluboxes -> blue boxes, initalised -> initialised, initalise -> initialise, seperated -> separated, seperate -> separate, seperator -> separator
Issue migrated from trac:4612 at 2022-04-16 12:45:16 -0700
The text was updated successfully, but these errors were encountered: