Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

do not attempt loading of missing videos to fix graphics glitch caused by video text #4631

Closed
wzdev-ci opened this issue Sep 6, 2017 · 6 comments
Closed

do not attempt loading of missing videos to fix graphics glitch caused by video text #4631

wzdev-ci opened this issue Sep 6, 2017 · 6 comments
Labels
closed component: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Sep 6, 2017

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon

When campaign videos are to be played, text is added to the front and bottom of the screen (see './src/seqdisp.cpp' for the responsible functions). If they are missing, this text causes a graphics glitch: For an instant, it is displayed (see attached image [raw-attachment:campaign_mission_backdrop.png]) and in the intelligence display it briefly overlaps with the next screen when clicking on intelligence widgets. It also causes an error message in the logs, as below:

info |00:10:00: [seq_Play:509] unable to open 'sequences/cam1/c001.ogg' for playback

This patch ensures no further attempts to load missing videos by checking whether the file './sequences/devastation.ogg' (i.e. the intro video) is available.

Issue migrated from trac:4631 at 2022-04-16 12:54:11 -0700
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Forgon uploaded file campaign_mission_backdrop.png (12.0 KiB)

video text for first mission of Beta Campaign above a black screen because no videos are installed
campaign_mission_backdrop.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Forgon uploaded file load_no_missing_videos.patch (4.6 KiB)

patch file created with git format-patch

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 6, 2017

Berserk Cyborg committed [81]

In Warzone2100/warzone2100@81bf128:

#CommitTicketReference repository="" revision="81bf12847181ce7ddc7b096f2049e2c8bb949e35"
Do not try loading missing videos.

Patch by forum member Forgon.
Fixes #4631.

@wzdev-ci wzdev-ci closed this as completed Sep 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci