Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Campaign alliance shared vision after saveload #4673

Closed
wzdev-ci opened this issue Nov 22, 2017 · 9 comments
Closed

Campaign alliance shared vision after saveload #4673

wzdev-ci opened this issue Nov 22, 2017 · 9 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Berserk Cyborg


I documented this before though I think it should be separate. The player receives the vision field of an ally player when loading a savegame. Most of the time everything is hidden, despite being brighter than the surroundings, but on occasion a few things might show up in the area. For example, the two angel missile emplacements become visible once they fire at something.


Issue migrated from trac:4673 at 2022-04-16 12:57:26 -0700

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file vis.jpeg (119.8 KiB)

shared vision of ally

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg uploaded file 0001-Prevent-vision-gifting-upon-saveload-for-campaign.patch (1.0 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg commented


I think that will prevent it from giving the player an ally vision field. It seems to stop those mapTile asserts also?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Per commented


guman -> human, otherwise patch looks good to me.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 2, 2017

Berserk Cyborg committed [8]


In Warzone2100/warzone2100@8c9e726:

#CommitTicketReference repository="" revision="8c9e7260333d6388438a091aad493bd2e11a965e"
Prevent vision gifting upon saveload for campaign.

When loading a save the human player, 0, would be given an ally's vision.

Fixes #4673.

EDIT: Guess we don't want invisible units then, heh. e36ebcf38e76a4992878dec18f040f7db41851c7.

@wzdev-ci wzdev-ci closed this as completed Dec 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant