Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Script Naming Convention Inconsistency Corrections #4674

Closed
wzdev-ci opened this issue Nov 24, 2017 · 9 comments
Closed

Script Naming Convention Inconsistency Corrections #4674

wzdev-ci opened this issue Nov 24, 2017 · 9 comments
Labels
closed component: Data: Scripts (Campaign) normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by Hironaru

Hi there,

First patch ever (woot coding). I am Hironaru, and while I was proposing my first re-balancing proposal for community review for Cam1a and Cam1b; I noticed some nifty things about some of the code surrounding the "baba" or scav weapons.

Namely, that some were simply prefixed with "B" or lower case letters, were out of order in the alphabetical sequence or lacked the baba identifier altogether (The BusCannon, for example).

Scav towers were also erroneously using the BuggyMG weapon, and were not using the "BTowerMG" weapon. In fact, "BTowerMG wasn't even being used. So I also threw that fix in there and matched the values from buggy to avoid changing balance at this time. This key referencing difference will be essential as I progress in the re-balancing effort, because I may need to adjust one value or the other.

And on a final note, I went ahead and changed the MP Scripts as well for consistency. If you feel like they would break something I'm not aware of in MP (I'm focusing only on campaign script interactions) then feel free to omit the mp stuffs.

Thanks for allowing me to assist with this project so far!

Hironaru
Project BOMB

Issue migrated from trac:4674 at 2022-04-16 12:57:30 -0700
@wzdev-ci
Copy link
Contributor Author

Hironaru uploaded file Script Clean WZ2100.zip (42.2 KiB)

Contains Data files for baba weapon prefixes / babatower weapon call fix

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented

Try not to reorder the stats into alphabetical order because it makes it harder to see what is being changed. Leave that for the very end of the project.

These changes will more than likely break savegames on Alpha campaign and Beta 5 (which, although tedious, can be amended by manually editing the files with the right components provided the save is not on a scavenger mission).

If anyone else wants to review the changes from the above attachment:
KJeff01/warzone2100@2cb0945

Differences from the attachment above include changing the skirmish scav tower to use the tower MG since it used the buggy MG and fixed the A0CannonTower structure weapon stat name. And the cam2-c script reference.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg committed [25]

In Warzone2100/warzone2100@25de299:

#CommitTicketReference repository="" revision="25de2991b2da64125c8c863aeaafe4bec50ad81d"
Scavenger stat naming consistency for base.

Scavenger stats follow a similar naming convention.

Closes #4674. Changes from forum member Hironaru.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Data: Scripts (Campaign) normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci