Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

update deprecated build instructions #4701

Closed
wzdev-ci opened this issue Jan 10, 2018 · 10 comments
Closed

update deprecated build instructions #4701

wzdev-ci opened this issue Jan 10, 2018 · 10 comments
Labels
closed component: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon

The script ./autogen.sh printed two warnings:

configure.ac:75: You should use the Autoconf-provided 'AC_PROG_MKDIR_P' macro instead,
configure.ac:75: and use '$(MKDIR_P)' instead of '$(mkdir_p)'in your Makefile.am files.

tests/Makefile.am:38: warning: source file '../tools/map/mapload.cpp' is in a subdirectory,
tests/Makefile.am:38: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled.  For now, the corresponding output
automake: object file(s) will be placed in the top-level directory.  However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
+ removing config.cache ...

Build instructions also contained a references to quesoglc, which has long been replaced with harfbuzz (see ticket #4507). Some of our packagers may still think that it is required to build the game: I informed the Fedora project that this is not the case (read the bug report for their package).

Issue migrated from trac:4701 at 2022-04-16 12:59:33 -0700
@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file autogen_error.log (1.3 KiB)

complete command line output of ./autogen.sh

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file autogen_warnings.patch (1.2 KiB)

patch file created with git format-patch (part 1/2)

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file quesoglc_cleanup.patch (1.8 KiB)

patch file created with git format-patch (part 2/2)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed owner from `` to Forgon2100 <forgon2100@gmail.com>

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> commented

In Warzone2100/warzone2100@cd3ee27:

#CommitTicketReference repository="" revision="cd3ee27fa76f8fa692a86f8c9cfff24416e70fc9"
fixes #4701: fix autogen.sh warnings (patch 1/2)

@wzdev-ci
Copy link
Contributor Author

Forgon2100 <forgon2100@...> committed [60310209627]

In Warzone2100/warzone2100@6031020:

#CommitTicketReference repository="" revision="60310209627e19eb210f5a3956236110a7923f6d"
fixes #4701: remove references to quesoglc that was replaced with harfbuzz a long time ago (patch 2/2)

@wzdev-ci
Copy link
Contributor Author

Forgon edited the issue description

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 2, 2019

Polynomial-C committed [0409]

In Warzone2100/warzone2100@0409f55:

#CommitTicketReference repository="" revision="0409f551ff5483571a40b9503940806fbd5f2984"
configure.ac: Raise AM_GNU_GETTEXT_VERSION to 0.17

the shipped copy of po/Makefile.in.in comes from gettext-0.17 and since
m4/po.m4 has been changed to use AC_PROG_MKDIR_P (Trac ticket #4701)
autopoint from gettext would produce a broken po/Makefile.in.in which has
no MKDIR_P definition. This again would result in "make install" throwing
the following error when invoking install-data-yes target in /po/ dir:

  make[1]: execvp: /usr/share: Permission denied

Raising AM_GNU_GETTEXT_VERSION fixes the described issue.

Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci