Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

broken buildbot releases #4702

Closed
wzdev-ci opened this issue Jan 10, 2018 · 9 comments
Closed

broken buildbot releases #4702

wzdev-ci opened this issue Jan 10, 2018 · 9 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Forgon


When downloading this game from http://buildbot.wz2100.net/files/master/linux and compiling it, make fails because some files in the subdirectory './3rdparty/micro-eec' is missing in the archive buildbot provides (see [raw-attachment:make_error.log]).

Comparing its contents with git's master branch using diff -qr github buildbot reveals more missing files and directories, most importantly files in './3rdparty/miniupncp' (see [raw-attachment:github_buildbot.diff]).

Besides, buildbot still does not provide builds for MacOSX users.


Issue migrated from trac:4702 at 2022-04-16 12:59:37 -0700

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file make_error.log (1.4 KiB)

complete command line output of ./make

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file github_buildbot.diff (7.7 KiB)

command line output of diff -qr github buildbot (slightly edited to account for effects of current buildbot downtime)

@wzdev-ci
Copy link
Contributor Author

Per commented


Buildbot never made builds for MacOSX. We really would need a Mac server to do that.

@wzdev-ci
Copy link
Contributor Author

vexed commented


The directories you mention ARE indeed there.

There is a difference between what is in the repo, and how we handle distributions.

In this specific case, you just need to do something like...

noinst_HEADERS = \
        platform-specific.inc \
	types.h \
	uECC_vli.h \
        uECC.h

to warzone2100/3rdparty/micro-ecc/Makefile.am

I would push this fix, however, I can't compile anything at the moment, so I can't see what else is missing (if anything), but just add things that are really needed there or in the EXTRA_DIST depending on what it is.

Per can push it, and check if anything else is needed.

As for mac builds, as Per said, we have NEVER gotten that to work with the build-bot, since Apple refuses to let people without actual macs do things like that, besides, we also need a Apple developer license to do releases.

Oh, and for what it is worth, people should NOT use the tarball from github, since we do some extra stuff with builds, and the github tarball won't compile "as is" either, without having to generate some files that we generate at compile time.

@wzdev-ci
Copy link
Contributor Author

Forgon edited the issue description

@wzdev-ci
Copy link
Contributor Author

vexed changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

vexed changed owner from `` to vexed

@wzdev-ci
Copy link
Contributor Author

vexed changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

vexed committed [97]


In Warzone2100/warzone2100@97a25c1:

#CommitTicketReference repository="" revision="97a25c1272da0557412431c8f547de02135d3799"
Fix missing files for out of tree builds.
Debugged with the help from Berg.

Fixes #4702

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant