alfred007 commented

I can confirm this with master be3858f

Forgon changed blocking which not transferred by tractive

Forgon changed blockedby which not transferred by tractive

Forgon commented

The problem was introduced in

commit 2810c730e1733262b3ff27decfbb93c1db821a6a
Author: Per Inge Mathisen <per.mathisen@gmail.com>
Date:   Wed Nov 29 21:50:35 2017 +0100

    Move reticule button enable/disable control into scripts.
    
    New qtscript features:
    - setReticuleFlash(id, value) - make reticule button flash
    - levelType - read type of level (set in .lev file)

Forgon changed status from new to closed

Forgon changed resolution from `` to fixed

Forgon commented

Fixed in 42db8f72193b348ea16f942c8bda4a40cb11cb23.

alfred007 commented

I updated to this master, started a new alpha campaign and it didn't work.

alfred007 changed status from closed to reopened

alfred007 changed resolution from fixed to ``

Forgon changed priority from normal to blocker

Forgon commented

Replying to Warzone2100/old-trac-import#4715 (comment:4):

I updated to this master, started a new alpha campaign and it didn't work.

Thanks for testing. This bug is obviously a release blocker.

Berserk Cyborg commented

Rule.js do not subscribe to eventKeyPressed. It should have been added into that commit, but whatever. I am testing it now.

Berserk Cyborg commented

Anyone want to do a quick test with the below patch?

Forgon changed _comment0 which not transferred by tractive

Forgon commented

Replying to Warzone2100/old-trac-import#4715 (comment:8):

Anyone want to do a quick test with the below patch?

Honestly, I am still not happy with this approach. Why do we need to hardcode F1-F6 in several places rather than in one place with all other keyboard shortcuts?

Edit: I tested your patch. It (unsurprisingly) does not work for the tutorial.

Berserk Cyborg commented

It appears that it only checks some obscure state flag for the button to see if a menu should be opened (which did not survive 2810c730e1733262b3ff27decfbb93c1db821a6a).

Berserk Cyborg uploaded file 0001-Use-the-reticule-key-enable-state-again.patch (1.3 KiB)

Berserk Cyborg changed status from reopened to closed

Berserk Cyborg changed owner from `` to Berserk Cyborg

Berserk Cyborg changed resolution from `` to fixed

Berserk Cyborg committed [9476]

In Warzone2100/warzone2100@9476a9a:

#CommitTicketReference repository="" revision="9476a9a735a63ae9739ff3a56c4823f11b40cfd0"
Use the reticule key enable state again.

Keys F1-F6 to open reticule menus were broken with commit 2810c730e1733262b3ff27decfbb93c1db821a6a.
Fixes #4715.

Forgon changed status from closed to reopened

Forgon changed resolution from fixed to ``

Forgon commented

In the tutorial, reticule buttons still do not work correctly: For example, two reticule buttons are visible and can be clicked on at its beginning, yet their keyboard shortcuts fail.

Berserk Cyborg commented

Marked #4774 as duplicate.

Berserk Cyborg uploaded file 0001-Move-reticule-hack-to-include-campaign-saveload.patch (1.9 KiB)

Berserk Cyborg uploaded file 0002-Move-reticule-button-disabling.patch (5.6 KiB)

Berserk Cyborg committed [2]

In Warzone2100/warzone2100@2cb78d4:

#CommitTicketReference repository="" revision="2cb78d4c267362014c9d2aa064081f2112b90848"
Move reticule hack to include campaign saveload.

Otherwise the campaign reticule shortcuts will fail.

Refs ticket 4715.

Berserk Cyborg changed status from reopened to closed

Berserk Cyborg changed resolution from `` to fixed

Berserk Cyborg commented

In Warzone2100/warzone2100@be001e3:

#CommitTicketReference repository="" revision="be001e37cc3695ca9d77fd174e57d22551ed9a28"
Move reticule button disabling.

Closes ticket 4715.