Prot commented

http://forums.wz2100.net/viewtopic.php?f=6&t=13933

Per changed blocking which not transferred by tractive

Per changed blockedby which not transferred by tractive

Per commented

What NVidia card do you have, what driver version, what platform (linux/windows), and what FPS results do you get?

Prot commented

Replying to Warzone2100/old-trac-import#4722 (comment:2):

What NVidia card do you have, what driver version, what platform (linux/windows), and what FPS results do you get?
I tested only on Windows 10, Debian 8 and Arch linux, no Mac OS.
Cards: Nvidia 440 GT, Nvidia 680 GTX, AMD Radeon R7 M260DX
Now will add screenshots from windows 10 on forum.

Forgon uploaded file ticket_4722_1ce7e09ba.png (459.7 KiB)

screenshot after last working commit 1ce7e09bab668d06022fdae33c4132043658bbc

Forgon uploaded file ticket_4722_a6017da6a.png (416.9 KiB)

screenshot after first faulty commit a6017da6a838ba17630a629d6c3c8c4483c09ccc with widget frames broken

Forgon uploaded file ticket_4722_ae2e4c0e2.png (416.8 KiB)

screenshot after second faulty commit ae2e4c0e23d824dee6dde7464237fb854aa24ec7 with fps reduced from 60 to 50

Forgon uploaded file ticket_4722_c89320c2d.png (395.7 KiB)

screenshot of most recent commit c89320c2d5ef7bb2262ce3e2659cdd58e2fb2000 with fps slightly lowered from 50 to 47

Forgon commented

I reproduced the problem with ArchLinux using the integrated graphics card of the Intel i5-2540M processor powered by Mesa 17.3.3.2. Results:

commit 1ce7e09bab668d06022fdae33c4132043658bbc:
60 fps (see attached image [raw-attachment:ticket_4722_1ce7e09ba.png])

commit a6017da6a838ba17630a629d6c3c8c4483c09ccc:
60 fps with widget frames broken (see attached image [raw-attachment:ticket_4722_a6017da6a.png])

commit ae2e4c0e23d824dee6dde7464237fb854aa24ec7:
50 fps (see attached image [raw-attachment:ticket_4722_ae2e4c0e2.png])

commit c89320c2d5ef7bb2262ce3e2659cdd58e2fb2000:
47 fps (see attached image [raw-attachment:ticket_4722_c89320c2d.png])

Per commented

Is this fixed with the high-dpi build?

Berserk Cyborg commented

Nope. These two commits are the ones causing the performance loss: a6017da6a838ba17630a629d6c3c8c4483c09ccc and ae2e4c0e23d824dee6dde7464237fb854aa24ec7.

Per commented

To those who still have performance issues - are you CPU bound or GPU bound?

To tell which it is - try looking at 'top' (on linux) or performance monitor (windows), to see if you are at 100% CPU on the process running Warzone. If you are at 100% CPU on that process, then you are likely CPU bound. Otherwise you are GPU bound.

Also, make sure you turn vsync off if you cannot reach 60 fps.

Berserk Cyborg changed _comment0 which not transferred by tractive

Berserk Cyborg commented

Apparently I am GPU bound and I never have vsync on. It only really is slightly noticeable when the reticule research menu is open.

Edit:
I just noticed that the only widget that displays the black borders correctly is the results screen you see. Like on the win/lose scenario in a campaign mission.

Prot commented

Also flying black pixels at the top left, it is corners of minimap, if you try to resize minimap then you see how those pixels moves too.
high-dpi build - just boost graphics what we have now, if not for these commits a6017da6a838ba17630a629d6c3c8c4483c09ccc and ae2e4c0e23d824dee6dde7464237fb854aa24ec7 i think we would have had a double boost FPS.

Forgon changed priority from normal to blocker

Forgon uploaded file widget_borders.patch (1.7 KiB)

patch file created with git format-patch

Forgon commented

The missing window borders are caused by erroneous calls to the functions 'iV_DrawImageRepeatX()' and 'iV_DrawImageRepeatY()', both of which are declared in './lib/ivis_opengl/pieblitfunc.h'.

The errors had been introduced in commit a6017da6a838ba17630a629d6c3c8c4483c09ccc.

Please try my attached patch and improve on it if you can.

pastdue commented

@forgon: Fantastic catch!

Here's a (smaller) patch that fixes the root cause of the issue:
https://patch-diff.githubusercontent.com/raw/Warzone2100/warzone2100/pull/148.patch

In the definition of RenderWindowFrame, the modelViewProjection matrix was defaulting to glm::mat4().
It needs to default to defaultProjectionMatrix().

Berserk Cyborg commented

Replying to Warzone2100/old-trac-import#4722 (comment:12):

Here's a (smaller) patch that fixes the root cause of the issue
Works for me.

Replying to Warzone2100/old-trac-import#4722 (comment:9):

Also flying black pixels at the top left, it is corners of minimap, if you try to resize minimap then you see how those pixels moves too.

I thought it was only one little triangle when it is in fact an outline matching the dimensions of the mini-map.

Berserk Cyborg uploaded file pixel.png (803.9 KiB)

Berg commented

I think the black border is the no go part of the warzone map its a area on the edges of the map that you cant build on or drive on

Forgon changed _comment0 which not transferred by tractive

Forgon commented

Replying to Warzone2100/old-trac-import#4722 (comment:13):

Replying to Warzone2100/old-trac-import#4722 (comment:12):

Here's a (smaller) patch that fixes the root cause of the issue
Works for me.

Replying to Warzone2100/old-trac-import#4722 (comment:9):

Also flying black pixels at the top left, it is corners of minimap, if you try to resize minimap then you see how those pixels moves too.

I thought it was only one little triangle when it is in fact an outline matching the dimensions of the mini-map.

This is the mini map border, which is drawn in the wrong place since commit a6017da6a838ba17630a629d6c3c8c4483c09ccc.

It is visible with my patch (see attached image [raw-attachment:minimap_border_error.png]), but not with your patch.

Forgon uploaded file minimap_border_error.png (406.5 KiB)

minimap border drawn in wrong location

pastdue changed _comment0 which not transferred by tractive

pastdue commented

@forgon: Then there's a remaining call to RenderWindowFrame that is passing in an incorrect modelViewProjection matrix. The culprit looks to be in DrawRadarExtras. Try removing modelViewProjectionMatrix from the call to RenderWindowFrame inside DrawRadarExtras. (Am not able to test right now.)

pastdue commented

To all: Please see the updated patch at: https://github.com/Warzone2100/warzone2100/pull/148.patch

This also fixes the drawing of the radar frame corners, which weren't respecting the input modelViewProjectionMatrix.

past-due <30942300+past-due@...> changed status from new to closed

past-due <30942300+past-due@...> changed owner from `` to past-due <30942300+past-due@users.noreply.github.com>

past-due <30942300+past-due@...> changed resolution from `` to fixed

past-due <30942300+past-due@...> committed [1]

In Warzone2100/warzone2100@1a1b075:

#CommitTicketReference repository="" revision="1a1b0750506b663055f71f856c1079ba576b8a14"
fixes #4722: fix drawing of widget borders

Co-Authored-By: Forgon2100 <forgon2100@users.noreply.github.com>

past-due <30942300+past-due@...> commented

In Warzone2100/warzone2100@fedcb22:

#CommitTicketReference repository="" revision="fedcb22aec21387ce4ea4c64bf9453e5183fc3ef"
fixes #4722: Frame corners should respect the input modelViewProjectionMatrix

This fixes the drawing of the radar frame corners.