Berserk Cyborg uploaded file Gamma4.zip (65.5 KiB)

Use "let me win" cheat when offworld

Per Inge Mathisen <per.mathisen@...> committed [530]

In Warzone2100/warzone2100@530d67a:

#CommitTicketReference repository="" revision="530d67a8b74025187edf80139edbd40bbfc4293a"
Fix more visibility asserts in campaign

Should not have visibility data in droids on
board a transporter, but these were created when
a game was loaded with droids already boarded.

Should not try to check for visibility toward the
campaign transporter, since it can be off-map and
off-map coordinates are crashy.

See #4743

Per commented

I don't even get that far. It asserts so much on the way. This savegame is goldmine of reproducible bugs...

Current bug is that the landing zone coordinates for the AI player (player 3) on the map we go to are off-map, which causes an assert when the VTOLs want to fly to rearm to this off-map location. Are they supposed to fly off-map? (Not sure if the our current code expects that any non-transporter goes off-map.)

Per commented

It uses the landing zone info from the savegame (setNoGoArea(47, 52, 49, 54, 3)). The landing zone info for the current player is overwritten from the scripts when going off-world, but the landing zone info for the AIs is kept unchanged, which I think is a mistake here.

Berserk Cyborg changed _comment0 which not transferred by tractive

Berserk Cyborg commented

There is no rearming for the hit-and-run VTOLs (at least now anyway). They are created on a position coordinate, do whatever they do, then fly toward an area event and get removed when damaged enough or have no ammo.

Lots of MapTile asserts (easy to see with this save) cause the transporter gets pulled away from where it is trying to get to (cause it left the home map in different direction) and thus goes far off map for a while. It also happens upon disembarking the droids (revealing features?).

VTOLs can cause mapTile asserts when they turn around near an edge of a map and go off the map bounds for a little while.

And fpath errors also.

Per commented

The script needs to set a valid landing zone for the player that owns these VTOLs. The mapTile and fpath asserts come because the landing zone they are trying to reach is invalid.

Per commented

The structure limit issue happens because as the transporter enters the new area, the scripts set the structure limit for HQs to zero, and does not set it back before exiting.

Berserk Cyborg committed [8]

In Warzone2100/warzone2100@8e883e8:

#CommitTicketReference repository="" revision="8e883e826fdc6ad41fefae8ab0d70985f8a2d597"
Stop structure limit warning when returning to home map.

Reset structure limits for HQ and command relay, for the player, after every mission end to
stop warnings about too many of them on map. Those structures were limited when going
off-world, but not reset when returning.

Refs #4743.

Berserk Cyborg commented

Replying to Warzone2100/old-trac-import#4743 (comment:5):

The script needs to set a valid landing zone for the player that owns these VTOLs. The mapTile and fpath asserts come because the landing zone they are trying to reach is invalid.
I created new LZ areas in 8ff55033187ca7fd413756040a576bc5f576b01d and 749af07f8c4b4b093d03d136370cb64ceef7773a for Beta/Gamma which change with each mission.

Per changed status from new to closed

Per changed resolution from `` to fixed