Berg uploaded file shadows.png (286.7 KiB)

showing shadows

Berg commented

Also the_cybersphinx tracked the code spot down can this be changed to suit the truck shadows
[10:04] the_cybersphinx Berg: src/display3d.cpp line 1149.

Berg commented

It seems changing
const Vector3f theSun(225.0f, -600.0f, 450.0f);
to
const Vector3f theSun(225.0f, -600.0f, -450.0f);
it inverts the suns direction on both leaving the result opposite to what we had but also no good.

Forgon changed status from new to closed

Forgon changed resolution from `` to duplicate

Forgon changed blocking which not transferred by tractive

Forgon changed blockedby which not transferred by tractive

Forgon commented

Unfortunately, I must close this ticket. It is a duplicate of ticket #4744.

Berg commented

This has more info leave it open

Berg changed status from closed to reopened

Berg changed resolution from duplicate to ``

pastdue changed type from bug to patch (an actual patch, not a request for one)

pastdue commented

And here is a tentative patch: https://patch-diff.githubusercontent.com/raw/Warzone2100/warzone2100/pull/142.patch

Testing and feedback is appreciated.

Berserk Cyborg commented

Looked through several maps and saw nothing immediately worrisome. Overall, nice job. The top of cliffs can look somewhat darker than normal, however, that existed before this patch anyway (the skirmish map Bloat(5p) shows it well).

pastdue commented

@BerSerK Cyborg: Yep, the only thing the patch modifies is the sun vector used for calculating terrain lighting / shadows. So any other terrain lighting / drawing behavior should be unchanged. Thanks for giving it a test!

Berserk Cyborg changed priority from normal to major

Berserk Cyborg changed status from reopened to closed

Berserk Cyborg changed resolution from `` to fixed

Berserk Cyborg changed title from shadows falling wrong way to Terrain lighting opposite of sun location

Berserk Cyborg commented

Merged. It recalculates lighting when changing the sun position so I see nothing wrong here.

ec8a386f1e65246de3807f15ec510236dd652597 and c68a43790161e69abf5053ef21a9150b2d131ae2.