Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

fix broken upgrade icons #4759

Closed
wzdev-ci opened this issue Mar 8, 2018 · 12 comments
Closed

fix broken upgrade icons #4759

wzdev-ci opened this issue Mar 8, 2018 · 12 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Mar 8, 2018

resolution_fixed type_bug | by Forgon


In the main menu screen there is a button to check whether a newer game version is available.
It had been introduced in

`
commit b92a1d9328223f50911833fe5a0aa285bc3fd02c
Author: vexed vexed@wz2100.net
Date: Wed Dec 17 22:00:56 2014 -0500

Introduce a rudimentary way to check if they have the latest version of the game. (Part 1)

refs #4257
refs #4259

'

The button icons contained superfluous pixels (see attached images [raw-attachment:gameversion_icon_old.png] and [raw-attachment:gameversion_highlight_icon_old.png]).

I corrected them (see attached images [raw-attachment:gameversion_icon_new.png] and [raw-attachment:gameversion_highlight_icon_new.png]).

This was done using Gimp, keeping in mind to:

  • ensure that the image mode is "RGB" rather than "Indexed", because the images use an 8-bit colour map (see attached image [raw-attachment:gimp_rgb_mode.png])
  • increase contrast for easier spotting of faulty pixels, e.g. by setting Transparency Check Style via the 'Edit->Preferences' menu (see attached image [raw-attachment:gimp_dark_checks.png])
  • ensure all wrong pixels have been removed by clicking on empty area on the canvas with the "Fuzzy Select" tool using the keyboard shortcut "U" (see attached image [raw-attachment:gimp_fuzzy_tool.png])

The dark colours for UI elements in the Gimp screenshots are caused by the theme "Tactile" and do not influence the result.


Issue migrated from trac:4759 at 2022-04-16 13:04:12 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file upgrade_icons.patch (4.9 KiB)

patch file created with git format-patch

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gameversion_icon_old.png (1.3 KiB)

game version icon before this patch
gameversion_icon_old.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gameversion_icon_new.png (1.0 KiB)

game version icon after this patch
gameversion_icon_new.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gameversion_highlight_icon_old.png (1.8 KiB)

highlighted game version icon before this patch
gameversion_highlight_icon_old.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gameversion_highlight_icon_new.png (1.8 KiB)

highlighted game version icon after this patch
gameversion_highlight_icon_new.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gimp_rgb_mode.png (118.4 KiB)

setting image mode to "RGB" in Gimp with Tactile theme
gimp_rgb_mode.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gimp_dark_checks.png (126.4 KiB)

setting transparency check style to "dark checks" in Gimp with Tactile theme
gimp_dark_checks.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon uploaded file gimp_fuzzy_tool.png (68.2 KiB)

detecting all non-transparent pixels by using the "Fuzzy Select" tool in Gimp with Tactile theme
gimp_fuzzy_tool.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon2100 <forgon2100@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon2100 <forgon2100@...> changed owner from `` to Forgon2100 <forgon2100@gmail.com>

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon2100 <forgon2100@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Mar 8, 2018

Forgon2100 <forgon2100@...> committed [11]


In Warzone2100/warzone2100@11fc00b:

#CommitTicketReference repository="" revision="11fc00b329551893d88b8f837702c4af43d53240"
fixes #4759: fix broken upgrade icons

@wzdev-ci wzdev-ci closed this as completed Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant