Forgon changed blocking which not transferred by tractive

Forgon changed blockedby which not transferred by tractive

Forgon commented

Not allowing the user to change the screen resolution in windowed mode is a terrible UX decision, as I have already argued before. This user just independently arrived at the same conclusion.

I hope that Per reconsiders his decision.

pastdue changed _comment0 which not transferred by tractive

pastdue changed _comment1 which not transferred by tractive

pastdue commented

@berg:

On the full-screen resolution change - this absolutely should work, and it sounds like the attempt to change is failing (as reported by SDL). We'll need a debug log that outputs the fullscreen resolutions that SDL is detecting. (It's also possible that a newer version of SDL has changed things.)

EDIT:

It would also be very helpful to get the exact Linux distribution, version, & window manager you are using, so I can try to reproduce.

@forgon:

On the separate point you raised about changing the windowed resolution, let's take it in two pieces.

1. Changing the windowed resolution via the command-line:

As has been discussed on the forums and elsewhere, Warzone does nothing to prevent you from specifying the window resolution in windowed mode via the command-line.

However, your window manager may prevent specifying the windowed resolution from the command-line from working, especially if you have a tiling window manager. The details are in the forum post here: http://forums.wz2100.net/viewtopic.php?f=6&t=13846&start=105#p140368

2. Changing the windowed resolution in-game from the Video options menu:

There is no way to enable resizing the windowed resolution from the Video options menu without seriously breaking on a number of different OSes and window managers. As in the game breaks, and is unusable. This is an artifact of how those OSes and window managers handle & report window resizing events through SDL when initiated by the app, and it affects so many that there is no point in blacklisting / whitelisting them. Plus we currently have no APIs to detect them.

It's also completely unnecessary: you can now resize the window the same way all windows are resized (as the window is now resizable). Just click and drag a corner / side / whatever your window manager support for resizing windows.

On the UX for this:

At the moment, per @per, we do the following when in windowed mode (in the Video Options menu):

• Grey-out & disable the screen resolution
• But still display it, so the user knows the exact resolution of the window
• Display a tooltip that explains this (which probably needs translating into different languages)

We could completely hide the Resolution option in the Video menu when in windowed mode, but then there wouldn't be a way for users to readily see the exact window resolution. I am very much open to ideas of how to improve this UX, but there are trade-offs that make the optimal solution non-obvious.

pastdue changed title from screen res cant be changed to Fullscreen resolution change fails

pastdue changed status from new to assigned

pastdue changed owner from per to pastdue

pastdue commented

Fixed in commit: f8cb54cdaa58dae77a2792875180b2f8e73dd75f

The problem Berg discovered was reproducible by using Alt+Enter to toggle fullscreen while the Video Options menu was open. Fixed by properly refreshing the full Video options menu if the window state changes while it's open.

pastdue changed status from assigned to closed

pastdue changed resolution from `` to fixed