Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

derrick sound effect not playing in master #4766

Closed
wzdev-ci opened this issue Mar 30, 2018 · 16 comments
Closed

derrick sound effect not playing in master #4766

wzdev-ci opened this issue Mar 30, 2018 · 16 comments
Labels
closed component: Engine: Sound normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Berg

erg@berg-desktop ~/bin/warzone2100 $ grep -r "powerhum.ogg"
 
Binary file src/warzone2100 matches
Binary file build/data/base.wz matches
Binary file .git/index matches
Binary file data/base.wz matches
data/base/wrf/audio.wrf:file        WAV "powerhum.ogg"
data/base/audio/audio.cfg:  audio   "powerhum.ogg"  loop     10 1800
Binary file lib/sound/libsound.a matches
lib/sound/audio_id.cpp: {ID_SOUND_POWER_HUM,                           "powerhum.ogg"},
Binary file lib/sound/audio_id.o matches
berg@berg-desktop ~/bin/warzone2100 $
 
 
berg@berg-desktop ~/bin/warzone2100 $ grep -r "oilpump.ogg"
Binary file src/warzone2100 matches
Binary file build/data/base.wz matches
Binary file .git/index matches
Binary file data/base.wz matches
data/base/wrf/audio.wrf:file        WAV "oilpump.ogg"
data/base/audio/audio.cfg:  audio   "oilpump.ogg"   loop     3 1800
Binary file lib/sound/libsound.a matches
lib/sound/audio_id.cpp: {ID_SOUND_OIL_PUMP_2,                          "oilpump.ogg"},
Binary file lib/sound/audio_id.o matches

I looked in all the folders and these are the same listing for both sounds the power hum is working but the derrick sound is not.

Issue migrated from trac:4766 at 2022-04-16 13:04:40 -0700
@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented

See below patch. The sound is very quiet, so I don't know if we want to increase its volume (see top of audio.cfg) or not.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file 0001-Play-the-oil-pump-sound-effect.patch (1.3 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Berserk Cyborg commented

In Warzone2100/warzone2100@f8bdebf:

#CommitTicketReference repository="" revision="f8bdebfdc7d761bdf8627628e80be0c283b94d96"
Play the oil pump sound effect.

Fixes #4766.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Forgon changed status from closed to reopened

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Forgon changed resolution from fixed to ``

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 1, 2018

Forgon commented

The patch is quite wrong, and should be reverted.

I am working on a better alternative.

@wzdev-ci
Copy link
Contributor Author

WZ2100ModsFAn commented

Is this still going to be fixed?
i miss the ol' play oil pump sound...

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 19, 2018 •
edited

Forgon commented

Replying to Warzone2100/old-trac-import#4766 (comment:4):

Is this still going to be fixed?
i miss the ol' play oil pump sound...

The problem is complicated. In version 3.1.5, sounds are already not being played as they are supposed to. A quick fix is easy, but I would rather publish a proper solution. As you may have noticed, I have also worked on a few other tickets in recent weeks.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed status from reopened to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented

In Warzone2100/warzone2100@e307e88:

#CommitTicketReference repository="" revision="e307e88e97ff05ef7a54139922b2247aa9763143"
Play derrick pump sound.

The pump sound depends on the current animation of the derrick. This was presumably forgotten
about and wasn't reimplemented after commit af9c9137d231d4b2c1d4e5e1ffde0e86dc443b3c (see display3d.cpp diffs).

Turns up the sound volume a tiny bit, and, makes it a "oneshot" sound.

Closes #4766.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Sound normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci