Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

abolish sensor "Nexus Link" #4768

Closed
wzdev-ci opened this issue Apr 5, 2018 · 12 comments
Closed

abolish sensor "Nexus Link" #4768

wzdev-ci opened this issue Apr 5, 2018 · 12 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Apr 5, 2018

resolution_fixed type_patch (an actual patch, not a request for one) | by Forgon


The game currently contains a sensor called "Nexus Link", identical in appearance to the "CB Radar Turret". It is visible when using the cheat "give all" (see attached image [raw-attachment:sensor_nexus_link.png]).

This is not identical to the weapon "Nexus Link Turret" (see attached image [raw-attachment:weapon_nexus_link_turret.png]).

Is there a good reason not to remove that sensor?


Issue migrated from trac:4768 at 2022-04-16 13:04:50 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon uploaded file sensor_nexus_link.png (232.4 KiB)

design screen showing useless sensor "Nexus Link"
sensor_nexus_link.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon uploaded file weapon_nexus_link_turret.png (240.8 KiB)

design screen showing weapon "Nexus Link Turret"
weapon_nexus_link_turret.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon edited the issue description

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon uploaded file abolish_sensor_nexus_link.patch (2.7 KiB)

patch file created with git format-patch

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Berserk Cyborg commented


Didn't find anything that uses this particular sensor. I say it would be fine to remove it then.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon2100 <forgon2100@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon2100 <forgon2100@...> changed owner from `` to Forgon2100 <forgon2100@gmail.com>

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon2100 <forgon2100@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 5, 2018

Forgon2100 <forgon2100@...> commented


In Warzone2100/warzone2100@aacde23:

#CommitTicketReference repository="" revision="aacde23588e8a596a9764df6821d2d6abeeabf6d"
fixes #4768: abolish useless sensor "Nexus Link" (not the weapon with the same name!)

@wzdev-ci wzdev-ci closed this as completed Apr 5, 2018
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 6, 2018

Berg commented


why abolish a place holder for maybe a different weapon.
what is gained by removing it

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 6, 2018

Forgon changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 6, 2018

Forgon commented


Replying to Warzone2100/old-trac-import#4768 (comment:4):

why abolish a place holder for maybe a different weapon.
what is gained by removing it

Less confusion.
The sensor had the same name as the weapon "Nexus Link" and the same turret as the sensor "CB Radar Turret". Searching the code for any mentions of those two existing technologies (e.g. by using grep) would lead to the discovery of that sensor, whose purpose is unclear. Modders might also get misled into thinking the "Nexus Link" sensor is supposed to be used.
If you would like a "placeholder" turret (why?), implement it more cleanly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant