Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Some notes about eventObjectTransfer with structures #4819

Closed
wzdev-ci opened this issue Aug 3, 2018 · 5 comments
Closed

Some notes about eventObjectTransfer with structures #4819

wzdev-ci opened this issue Aug 3, 2018 · 5 comments
Labels
closed component: Engine: Scripting / AI normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Aug 3, 2018

resolution_fixed type_bug | by Berserk Cyborg

This all pertains to structures being donated. Droid donation is unaffected.

By adding

dump(obj.player + " " + obj.name + " from: " + from);

into the multiplayer rules.js eventObjectTransfer I saw that from always matches obj.player.

An eventObjectTransfer trigger for campaign currently does not exist. This is the main cause of several reticules not being enabled upon the transition event in Gamma 6 should no droid (truck or commander) be donated to the player. At least until some other reticule updating event happens, anyway.

Issue migrated from trac:4819 at 2022-04-16 13:08:16 -0700
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 4, 2018

Berserk Cyborg uploaded file 0001-Some-fixes-for-giftSingleStructure.patch (2.4 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 5, 2018

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 5, 2018

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 5, 2018

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Aug 5, 2018

Berserk Cyborg commented

In Warzone2100/warzone2100@af176e9:

#CommitTicketReference repository="" revision="af176e9eb32e393b26be6ef9c3329f6fc9006ab9"
Some fixes for giftSingleStructure.

-Fire off an eventObjectTransfer for campaign. Thus allowing rules.js to
update the reticules during the cam3-c transition and ally absorb event.
-In context of a script, the from parameter in eventObjectTransfer
was not the original player.
-Campaign fired eventStructureBuilt with the wrong structure.

Fixes #4819.

@wzdev-ci wzdev-ci closed this as completed Aug 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Scripting / AI normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci