Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

No weapon when destroy a factory #4836

Closed
wzdev-ci opened this issue Oct 20, 2018 · 12 comments
Closed

No weapon when destroy a factory #4836

wzdev-ci opened this issue Oct 20, 2018 · 12 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by corvax


Hi

During a session game "No place to hide" in Challenged mode when a factory is destroy there are no weapons to collect. In previous versions there were so I hope is a bug.
Congratulation for the game that change a lot since the PSX1 version.

Have a nice day


Issue migrated from trac:4836 at 2022-04-16 13:09:21 -0700

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


Did some digging and found that artifact drops from multiplayer factories was, I assume, mistakenly removed with af9c9137d231d4b2c1d4e5e1ffde0e86dc443b3c.

Note that I have only lightly tested the below patch on a skirmish and challenge.

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg uploaded file 0001-Restore-factory-artifact-drops-in-multiplayer.patch (0.7 KiB)

@wzdev-ci
Copy link
Contributor Author

Forgon changed _comment0 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

Forgon changed _comment1 which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Oct 26, 2018

Forgon commented


Replying to Warzone2100/old-trac-import#4836 (comment:1):

Did some digging and found that artifact drops from multiplayer factories was, I assume, mistakenly removed with af9c9137d231d4b2c1d4e5e1ffde0e86dc443b3c.

Note that I have only lightly tested the below patch on a skirmish and challenge.
Your fix should be mentioned in './ChangeLog' and "artifact" should not be spelt "artefact" (see attached file [raw-attachment:factory_artifact.patch]).

@wzdev-ci
Copy link
Contributor Author

Forgon uploaded file factory_artifact.patch (1.6 KiB)

patch file created with git format-patch

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed owner from `` to Berserk Cyborg

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Berserk Cyborg commented


In Warzone2100/warzone2100@fce314d:

#CommitTicketReference repository="" revision="fce314d5ba58778daa80a3626098729c8488005c"
Restore factory artifact drops in multiplayer.

Was mistakenly removed with commit af9c9137d231d4b2c1d4e5e1ffde0e86dc443b3c.

Fixes ticket 4836.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant