alfred007 uploaded file Incomplete Translation.jpg (245.2 KiB)

Forgon changed status from new to assigned

Forgon changed owner from `` to Forgon

Forgon changed blocking which not transferred by tractive

Forgon changed blockedby which not transferred by tractive

Forgon commented

Thank you, I will fix this.
There are several similar problems.
For example, challenge and AI descriptions are largely untranslated.

alfred007 commented

I think I have to clarify the situation. When you pick up the artifact in the game, the name of the artifact is translated. But in the Intelligence Display, the same name is not translated. So it's not necessary to translate it again but only to put a link into the .po file.

Berserk Cyborg commented

Couldn't we encapsulate the research names in intelmap.cpp with _()? Lines 320 and 456. Can' test this though.

psResearch->name.toUtf8().c_str() -> _(psResearch->name.toUtf8().c_str())

Forgon commented

Replying to Warzone2100/old-trac-import#4843 (comment:3):

Couldn't we encapsulate the research names in intelmap.cpp with _()? Lines 320 and 456. Can' test this though.

psResearch->name.toUtf8().c_str() -> _(psResearch->name.toUtf8().c_str())
Yes, this works.

Forgon commented

Replying to Warzone2100/old-trac-import#4843 (comment:2):

I think I have to clarify the situation. When you pick up the artifact in the game, the name of the artifact is translated. But in the Intelligence Display, the same name is not translated. So it's not necessary to translate it again but only to put a link into the .po file.
This is not how gettext works.
In any case, the problem is fixed now.

Forgon uploaded file intelligence_screen_translation_new.png (407.4 KiB)

translated title and button tooltip for research message in intelligence screen

Forgon uploaded file research_message_translation.patch (1.2 KiB)

patch file based on revision 356710b5c7efed84054b3b70003a6539dfb46265

Forgon2100 <forgon2100@...> changed status from assigned to closed

Forgon2100 <forgon2100@...> changed resolution from `` to fixed

Forgon2100 <forgon2100@...> commented

In Warzone2100/warzone2100@f1b170d:

#CommitTicketReference repository="" revision="f1b170db3012f4fcd99335cd814180ea8d37e0d6"
Fix translation of research messages

* show translations for titles and button tooltips of research messages
  in the intelligence screen

Fixes #4843