Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Default map: Use correct number of players #4849

Closed
wzdev-ci opened this issue Dec 8, 2018 · 9 comments
Closed

Default map: Use correct number of players #4849

wzdev-ci opened this issue Dec 8, 2018 · 9 comments
Labels
closed component: other normal
Milestone
unspecified

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Dec 8, 2018

resolution_fixed type_patch (an actual patch, not a request for one) | by Kreuvf

The patch in #4848 made the game use an already defined constant for the default map to show for skirmish games. Unfortunately, maps are not always loaded equally. Here, this means that the number of players is not read from the map, but is as hardcoded as the default map.

To fix the number of slots to use the actual number of players, I introduce the (rather ugly) DEFAULTSKIRMISHMAPMAXPLAYERS constant defined right where you would expect it: next to the definition of the default skirmish map.

While the patch is for 3.2.3, this should apply cleanly to master as well.

Issue migrated from trac:4849 at 2022-04-16 13:33:35 -0700
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Kreuvf uploaded file ease-changing-default-map-maxplayers.patch (2.0 KiB)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Steven Koenig <kreuvf@...> changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Steven Koenig <kreuvf@...> changed owner from `` to Steven Koenig <kreuvf@gna.org>

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Steven Koenig <kreuvf@...> changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Steven Koenig <kreuvf@...> committed [5807]

In Warzone2100/warzone2100@5807d38:

#CommitTicketReference repository="" revision="5807d38b51120e8782609f3b28d348624647f306"
Ease changing default map maxplayers.

Closes ticket 4849.

@wzdev-ci wzdev-ci closed this as completed Dec 8, 2018
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Berserk Cyborg changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Berserk Cyborg changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 8, 2018

Berserk Cyborg commented

Thanks!

BTW, you had the default set to 2 so I changed it to 4 since Rush is the official default map. :)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Dec 9, 2018 •
edited

Kreuvf commented

Replying to Warzone2100/old-trac-import#4849 (comment:2):

BTW, you had the default set to 2 so I changed it to 4 since Rush is the official default map. :)

Good catch xD

The patch originates from a mod project with a two-player map as the default map, so that's the simple reason behind it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: other normal
Projects
None yet
Milestone
unspecified
Development

No branches or pull requests
1 participant
@wzdev-ci