"research completed" sound should not play when clicking on a researched item #60
Comments
EvilGuru changed status from |
EvilGuru changed owner from `` to |
EvilGuru commented This is the offending code (from intelmap.c):
If the community can reach a consensus on this I'll happily remove the code in question (or leave it alone, depending on the aforementioned consensus). For a bottle of Gin I'll make it a configurable option (with the default being whatever the consensus is). |
Kreuvf commented The thing is that for every research-type mentioned in that piece of code in the original WZ a video has been played (that has audio that added some information on what type of research you researched) just to the right of the model. So a better option imho would be to extract the sound from the videos (they are GPL now, so we are allowed to do this :D) and replace the .ogg-files with the corresponding (correct) sound. |
Giel changed operating_system which not transferred by tractive |
Giel changed milestone from `` to |
Buginator changed blocking which not transferred by tractive |
Buginator changed blockedby which not transferred by tractive |
Buginator commented The intel FMVs don't have any sound. It repeats since we don't have a way to stop said sample. Well, easily that is. I was thinking we should just use a dedicated channel (source) for this, and all FMV related stuff, so we can stop it. |
Zarel changed priority from |
Zarel commented Well, now that we do have FMVs, thoughts? |
Buginator removed milestone (was |
Buginator commented Milestone 2.1 deleted |
Buginator changed status from |
Buginator set resolution to |
Buginator commented (In [11147]) Prevent overlapping sounds when looking at intel information. fixes #60 |
Buginator commented (In [11148]) Prevent overlapping sounds when looking at intel information. fixes #60 2.3:[11147] |
Buginator commented (In [11149]) Prevent overlapping sounds when looking at intel information. fixes #60 2.3: [11147] |
Git SVN Gateway <gateway@...> commented (In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]) Prevent overlapping sounds when looking at intel information. fixes #60 2.3:[11147] git-svn-id: https://warzone2100.svn.sourceforge.net/svnroot/warzone2100/trunk@11148 4a71c877-e1ca-e34f-864e-861f7616d084 |
Zarel set milestone to |
Zarel commented I think the easier solution would be just to not play that sound at all. I mean, I don't think it's much of a benefit, and it gets kind of annoying after a while, with or without the overlap... |
Git SVN Gateway <gateway@...> commented In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]:
|
1 similar comment
Git SVN Gateway <gateway@...> commented In [0dca1b06a1b7607f06d1b58a5869a3f3420e7f5b]:
|
resolution_fixed
type_patch (an actual patch, not a request for one)
| by rob@...When clicking on a researched item in the objectives screen, the sample "research completed" is played for every click. Thats simply annoying.
Issue migrated from trac:60 at 2022-04-15 17:41:16 -0700
The text was updated successfully, but these errors were encountered: