Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Crash if map preview during map download #756

Closed
wzdev-ci opened this issue Jul 26, 2009 · 9 comments
Closed

Crash if map preview during map download #756

wzdev-ci opened this issue Jul 26, 2009 · 9 comments
Labels
closed component: Engine: Networking minor

Comments

@wzdev-ci
Copy link
Contributor

keyword_map_preview resolution_fixed type_bug | by Per

Reported in http://forums.wz2100.net/viewtopic.php?f=4&t=3387

Workaroundish patch attached.

Issue migrated from trac:756 at 2022-04-15 19:03:09 -0700
@wzdev-ci
Copy link
Contributor Author

Per uploaded file preview1.diff (1.1 KiB)

Untested patch to fix crash if map preview during map download

@wzdev-ci
Copy link
Contributor Author

Buginator commented

Per, what do you think, stick this in 2.2.2 or wait?

It seems like it should work...but I don't see where you turn it on again so...

@wzdev-ci
Copy link
Contributor Author

anonymous commented

The idea behind the patch is that the last file chunk (recv function returns true) will turn the button on again. We should test it before committing.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 3, 2009

Per changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 3, 2009

Per set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 3, 2009

Per commented

(In [8079]) 2.2: Fix crash if map preview used during map download. Closes #756 reported by Firechkn34.

@wzdev-ci wzdev-ci closed this as completed Sep 3, 2009
@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Sep 3, 2009

Per commented

(In [8081]) Fix crash if map preview used during map download. Closes #756 reported by Firechkn34.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator commented

Milestone 2.2.3 deleted

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator removed milestone (was 2.2.3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed component: Engine: Networking minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wzdev-ci