Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

Improve proj_ImpactFunc #78

Closed
wzdev-ci opened this issue Sep 25, 2008 · 19 comments
Closed

Improve proj_ImpactFunc #78

wzdev-ci opened this issue Sep 25, 2008 · 19 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_patch (an actual patch, not a request for one) | by EvilGuru


The attached patch fixes a bug in proj_ImpactFunc whereby it would use the radius cubed as opposed to the radius squared when doing hit-detection. Furthermore it also removes some premature optimisations (hit-box detection).

More to come.


Issue migrated from trac:78 at 2022-04-15 17:42:42 -0700

@wzdev-ci
Copy link
Contributor Author

EvilGuru commented


The second part removes the (useless) concept of nominal damage — which occurs when a projectile hits the base-plate of a structure. Considering how infrequently this occurs and how little damage is done (5) there is little point keeping the functionality.

@wzdev-ci
Copy link
Contributor Author

EvilGuru uploaded file projectile.2.patch (2.6 KiB)

Part 2.

@wzdev-ci
Copy link
Contributor Author

EvilGuru commented


The third part removes some premature optimisation in the naybour functions.

@wzdev-ci
Copy link
Contributor Author

EvilGuru uploaded file projectile.3.patch (1.8 KiB)

Part three.

@wzdev-ci
Copy link
Contributor Author

EvilGuru commented


The fourth part removes the fire-box hack (another premature optimisation).

@wzdev-ci
Copy link
Contributor Author

EvilGuru uploaded file projectile.4.patch (5.7 KiB)

Part 4.

@wzdev-ci
Copy link
Contributor Author

Zarel commented


radSquared = psStats->radius * psStats->radius * psStats->radius;

Huh?

@wzdev-ci
Copy link
Contributor Author

EvilGuru commented


Thanks for catching that one! I should have probably done more than just rename the variable. New version attached/replaced.

@wzdev-ci
Copy link
Contributor Author

EvilGuru uploaded file projectile.1.patch (3.9 KiB)

Patch 1.

@wzdev-ci
Copy link
Contributor Author

DevUrandom changed status from new to accepted

@wzdev-ci
Copy link
Contributor Author

DevUrandom changed owner from `` to DevUrandom

@wzdev-ci
Copy link
Contributor Author

DevUrandom commented


Scheduling this for November. If you think this is urgent, tell me and I'll see when I find time to apply it without destroying my current work.

@wzdev-ci
Copy link
Contributor Author

anonymous changed blocking which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

anonymous changed blockedby which not transferred by tractive

@wzdev-ci
Copy link
Contributor Author

anonymous commented


Applied in [6498]-[6501].

@wzdev-ci
Copy link
Contributor Author

DevUrandom changed status from accepted to closed

@wzdev-ci
Copy link
Contributor Author

DevUrandom changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator removed milestone (was 2.2)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator commented


Milestone 2.2 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant