Improve proj_ImpactFunc #78
Comments
EvilGuru commented The second part removes the (useless) concept of nominal damage — which occurs when a projectile hits the base-plate of a structure. Considering how infrequently this occurs and how little damage is done (5) there is little point keeping the functionality. |
EvilGuru uploaded file Part 2. |
EvilGuru commented The third part removes some premature optimisation in the naybour functions. |
EvilGuru uploaded file Part three. |
EvilGuru commented The fourth part removes the fire-box hack (another premature optimisation). |
EvilGuru uploaded file Part 4. |
Zarel commented radSquared = psStats->radius * psStats->radius * psStats->radius; Huh? |
EvilGuru commented Thanks for catching that one! I should have probably done more than just rename the variable. New version attached/replaced. |
EvilGuru uploaded file Patch 1. |
DevUrandom changed status from |
DevUrandom changed owner from `` to |
DevUrandom commented Scheduling this for November. If you think this is urgent, tell me and I'll see when I find time to apply it without destroying my current work. |
anonymous changed blocking which not transferred by tractive |
anonymous changed blockedby which not transferred by tractive |
anonymous commented Applied in [6498]-[6501]. |
DevUrandom changed status from |
DevUrandom changed resolution from `` to |
Buginator removed milestone (was |
Buginator commented Milestone 2.2 deleted |
resolution_fixed
type_patch (an actual patch, not a request for one)
| by EvilGuruThe attached patch fixes a bug in proj_ImpactFunc whereby it would use the radius cubed as opposed to the radius squared when doing hit-detection. Furthermore it also removes some premature optimisations (hit-box detection).
More to come.
Issue migrated from trac:78 at 2022-04-15 17:42:42 -0700
The text was updated successfully, but these errors were encountered: