Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

burn baba burn! #830

Closed
wzdev-ci opened this issue Aug 21, 2009 · 14 comments
Closed

burn baba burn! #830

wzdev-ci opened this issue Aug 21, 2009 · 14 comments

Comments

@wzdev-ci
Copy link
Contributor

resolution_fixed type_bug | by Buginator


There really is no reason why a burning baba should have a choice between the scream, silence, and 'landing pad'.

audio_PlayObjDynamicTrack( psDroid, ID_SOUND_BARB_SCREAM+(rand()%3), NULL );

is clearly wrong, it should be %2, but I am making it so they always scream, like the PSX version.

Just making this ticket just in case someone asks why...


Issue migrated from trac:830 at 2022-04-15 19:08:01 -0700

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from new to closed

@wzdev-ci
Copy link
Contributor Author

Buginator set resolution to fixed

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [8025]) Closes and fixes #830
When babas are burning, we always play the scream now.
See #830 for more details.

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [8030]) Closes and fixes #830
When babas are burning, we always play the scream now.
See #830 for more details.

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from closed to reopened

@wzdev-ci
Copy link
Contributor Author

Buginator changed resolution from fixed to ``

@wzdev-ci
Copy link
Contributor Author

Buginator commented


Actually, looks like the real reason for this is that the sounds were mistakenly removed in [3270].

This means we have ID_SOUND_BARB_SCREAM, ID_SOUND_BARB_SCREAM2, ID_SOUND_BARB_SCREAM3, and the yell for help.

I am going to use ID_SOUND_HELP at a future date, so don't touch it.

I assume the reason Giel removed those was because he did a search in the source, and didn't see ID_SOUND_BARB_SCREAM2/3 being used, but they were tricky, and they did use them, just in a semi-sloppy way via this ID_SOUND_BARB_SCREAM+(rand()%3

@wzdev-ci
Copy link
Contributor Author

Buginator changed status from reopened to closed

@wzdev-ci
Copy link
Contributor Author

Buginator changed resolution from `` to fixed

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [8097]) revert [3270]
Bring back all the missing screams that were mistakenly removed, and also bring back the yell for help, since that will be used soon. (all removed in [3270])
Also reverts [8025] / [8030] (see #830 for more info) since I didn't know the sounds were removed.

fixes #830

@wzdev-ci
Copy link
Contributor Author

Buginator commented


(In [8102]) backport [8097]

revert [3270]
Bring back all the missing screams that were mistakenly removed, and also bring back the yell for help, since that will be used soon. (all removed in [3270])
Also reverts [8025] / [8030] (see #830 for more info) since I didn't know the sounds were removed.

fixes #830

@wzdev-ci
Copy link
Contributor Author

anonymous commented


HOW HEAR THIS ?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator removed milestone (was 2.2.2)

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented May 8, 2010

Buginator commented


Milestone 2.2.2 deleted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant