-Kosh- commented

Here is the fix so the delete routine can work correctly.

-Kosh- uploaded file deleteFix.patch (13.9 KiB)

Per changed status from new to accepted

Per set owner to Per

Per commented

I'll commit it with two fixes: Using PATH_MAX instead of MAX_PATH (no idea what the latter is - does not exist here), and using sstrcpy() instead of memcpy() for strings (always use this on static destination strings). Note that saving with spaces at the end of filenames works perfectly fine here.

Per changed status from accepted to closed

Per set resolution to fixed

Per commented

(In [8226]) Use temporary variable for manipulating filenames inside savegame function, so that original is not
clobbered on early failure return. Closes #981, patch by forum member Kosh.

Per changed status from closed to reopened

Per changed resolution from fixed to ``

Per changed milestone from 2.3 to unspecified

Per commented

I guess this should not be quite closed yet.

Zarel commented

What's unclosed about it? The fact that it hasn't been backported to 2.3?

-Kosh- commented

Replying to Warzone2100/old-trac-import#981 (comment:5):

What's unclosed about it? The fact that it hasn't been backported to 2.3?

That and the core of the problem is not fixed. If a error pops up someplace in the load routine after it read the .gam file it is not cleaned up correctly.

Here is another patch that correctly does removeWildcards()

All those listed are not supported by windows according to http://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx

For the issue that windows people had, the name "stuff 1 " is invalid when it comes to making a directory name "stuff 1 " because of the trailing space(s).
The game made "stuff 1 ".gam (valid) then it tried to make a directory called "stuff 1 " (invalid) and then it failed for everything after that.

With the removeWildcards() patch, if user enters "stuff 1 " it now becomes "stuff_1____". Could have just trimmed the trailing space(s) but I opted for the easier approach. :P

Whoever did removeWildcards() had a bad day it seems since that would have never worked, and it never did.

-Kosh- uploaded file wildcardfix.patch (0.9 KiB)

-Kosh- commented

I forgot to ask if there was a state diagram someplace floating around ?

anonymous commented

Replying to Warzone2100/old-trac-import#981 (comment:6):

Replying to Warzone2100/old-trac-import#981 (comment:5):

What's unclosed about it? The fact that it hasn't been backported to 2.3?

That and the core of the problem is not fixed. If a error pops up someplace in the load routine after it read the .gam file it is not cleaned up correctly.

Here is another patch that correctly does removeWildcards()

All those listed are not supported by windows according to http://msdn.microsoft.com/en-us/library/aa365247(VS.85).aspx

For the issue that windows people had, the name "stuff 1 " is invalid when it comes to making a directory name "stuff 1 " because of the trailing space(s).
The game made "stuff 1 ".gam (valid) then it tried to make a directory called "stuff 1 " (invalid) and then it failed for everything after that.

With the removeWildcards() patch, if user enters "stuff 1 " it now becomes "stuff_1____". Could have just trimmed the trailing space(s) but I opted for the easier approach. :P

Whoever did removeWildcards() had a bad day it seems since that would have never worked, and it never did.

Odd, it is not showing all the underscores? It shows one underscore like "" but not multiple like "__". I guess more than one underscore is a escape sequence of some type for trac?

Zarel commented

...yes, __text__ means text (underline text). After the first time, you probably should've tried preview. Use ``` to escape code, so escaped code becomes escaped code.

Like so:

For the issue that windows people had, the name "stuff 1 " is invalid when it comes to making a directory name "stuff 1 " because of the trailing space(s).
The game made "stuff 1 ".gam (valid) then it tried to make a directory called "stuff 1 " (invalid) and then it failed for everything after that.

With the removeWildcards() patch, if user enters "stuff 1 " it now becomes "stuff_1____". Could have just trimmed the trailing space(s) but I opted for the easier approach. :P

Whoever did removeWildcards() had a bad day it seems since that would have never worked, and it never did.

Zarel commented

And, ugh, underscores are ugly. Just get rid of trailing spaces. I will not tolerate underscores in my Warzone. D:

Zarel commented

Oh, and, you're wrong about removeWildcards, since you misunderstood how removeWildcards works.

removeWildcards may not have gotten rid of spaces, but it did remove wildcards correctly. Look carefully. What it does is get rid of all characters except alphanumeric characters, and ' ' '-' '+' '!', and replace them with '_'.

Zarel commented

Oh, and in your patch, everything after !isalnum(pStr[i]) is redundant. Did you miss the !? And what it does after that?

Zarel commented

I've committed a better fix for the trailing spaces in: [8227] and [8228]

Is that all (other than backporting to 2.3)?

-Kosh- commented

:o I misread that code.
The deletefix.patch should be in branch/2.2 as well.

I am really confused on what is going to be 2.3, will it be branch/2.2 or is the next version 2.2.4 and is current trunk going to be 2.5 or what?

I do not think this ticket can be closed until someone figures out how to cleanup everything once that .gam file loads and it fails in another part of the loading routine.

p.s why does your trac version not e-mail people when there is a reply?

Zarel commented

2.3 is currently branches/2.2. I call it 2.3 to emphasize that the next release of branches/2.2 will be some version of 2.3.

Buginator commented

Replying to Warzone2100/old-trac-import#981 (comment:14):

:o I misread that code.
The deletefix.patch should be in branch/2.2 as well.

I am really confused on what is going to be 2.3, will it be branch/2.2 or is the next version 2.2.4 and is current trunk going to be 2.5 or what?

I do not think this ticket can be closed until someone figures out how to cleanup everything once that .gam file loads and it fails in another part of the loading routine.

p.s why does your trac version not e-mail people when there is a reply?

You should be getting a e-mail, if not, then it is a bug.

For the other stuff you mentioned, (a corrupted .gam file), this is on my TODO list, and I am adding myself to the ticket.

vexed changed status from reopened to closed

vexed changed resolution from `` to fixed

vexed commented

Trailing spaces don't cause issues anymore.