Skip to content
This repository has been archived by the owner on Apr 17, 2022. It is now read-only.

ugly shadows, especially for HQ and scavengers #4767

Open
wzdev-ci opened this issue Apr 3, 2018 · 10 comments
Open

ugly shadows, especially for HQ and scavengers #4767

wzdev-ci opened this issue Apr 3, 2018 · 10 comments

Comments

@wzdev-ci
Copy link
Contributor

wzdev-ci commented Apr 3, 2018

type_bug | by Forgon


With shadows enabled, transparent areas of PIE models are drawn with a hideous background colour.
This is especially apparent with the HQ and scavenger infantry.

Both got noticeably more ugly with the following commit:

`
commit e7cb9372b2b8dfaa8736aee48aa5180c94db206d
Author: KJeff01 kjeff1997@gmail.com
Date: Sat Jan 13 23:00:10 2018 -0600

Draw opaque models before shadows.

'

To assess its effect on HQ antennas, look at:

  • the attached image [raw-attachment:shadow_drawing_old.png] to see its presence
  • the attached image [raw-attachment:shadow_drawing_new.png] to see its absence

I suggest to revert the mentioned commit.
Yet once that is done, shadow drawing still remains far from ideal. Surely we can do better?


Issue migrated from trac:4767 at 2022-04-16 13:04:46 -0700

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 3, 2018

Forgon uploaded file revert_shadow_drawing.patch (1.4 KiB)

patch file created with git format-patch

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 3, 2018

Forgon uploaded file shadow_drawing_old.png (87.9 KiB)

HQ antennas drawn with shadows enabled and commit e7cb9372b2b8dfaa8736aee48aa5180c94db206d
shadow_drawing_old.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 3, 2018

Forgon uploaded file shadow_drawing_new.png (88.2 KiB)

HQ antennas drawn with shadows enabled and without commit e7cb9372b2b8dfaa8736aee48aa5180c94db206d
shadow_drawing_new.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berserk Cyborg commented


I was under the impression that these are modeling issues (#4093). Scavenger units are messed up even with shadows off because a massive black square hangs under them at all times, and sometimes changes, just as moving the camera around the HQ antennas makes some of them look less choppy (or completely disappear). Not to mention the broken animations for them.

Said patch of mine was only to make shadows appear on objects, more realistic if you will, rather than be a mysterious darkened area next to objects (the now opaque base plates will be drawn over the shadows (among other things), again, if reverted as shown in that image above).

Why do these two objects create shadows in the first place, where as trees do not?

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

pastdue commented


I concur with Beserk Cyborg on this - I do not believe that reverting the ordering is the best approach to fixing the HQ antenna alpha issues.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berg commented


the shadows are of total polygon and not the part that is visible so by reducing the polygon size to match closer what the object shape is the shadow will better conform to the object.

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berg uploaded file hq.png (392.4 KiB)

shadow shape only and simple polygone shadow
hq.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berg uploaded file hq.2.png (329.0 KiB)

from 16 polygon per aireal to 40
hq.2.png

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berg commented


a quick modify of aireals less polygons than first attempt but still heaps more

@wzdev-ci
Copy link
Contributor Author

wzdev-ci commented Apr 4, 2018

Berg uploaded file blhq.pie (50.7 KiB)

HQ pie file

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant