Mysteryem uploaded file Editworldfiles.rar (14.0 KiB)

Mysteryem changed blockedby which not transferred by tractive

Mysteryem commented

Please notify me of any problems.

Per commented

I miss a better description of what the patch does. Am I right in assuming that it puts every feature into all three tilesets, but in such a way that all existing maps continue to work?

The change to data/base/features/miarthov.pie looks mistaken.

Why are many PIEs moved from one tileset to another (by texpage name)?

Mysteryem commented

Yes, all of the old maps should work fine.

I'll take a look at miarthov.pie, I'm not sure what's wrong with it.

Giving them individual texpages is my way of allowing them to work in all three tilesets, I have no idea how to code and since nobody was doing anything towards ticket #444 I decided to do this myself.

Per commented

What should be done with the Editworld files? How will this patch impact Editworld?

Mysteryem uploaded file newfeatures&universalfeatures.patch (104.7 KiB)

Updated to make a number of new/unused features use a larger texpage.

Mysteryem uploaded file data,base,texpages.rar (447.5 KiB)

Added page-6.png for arizona plants, pipes, wrecks and the "trap" pieces. page-30-features-rockies.png has also been fixed.

Mysteryem commented

If someone doesn't add the files for editworld then they won't be able to use any of the new features in their map. If someone opens a map with the new features and they don't have the files, editworld will remove them from the map.

Per commented

Should page-6 be removed?

Have you tested all relevant campaign transitions and seen that they still work?

Mysteryem commented

page 6 is now being used for the trees and a few other features to make their details (and edges) crisper.

That's a good point, I need to check that. And what is vidmemc.wrf for? It doesn't seem to be used as far as I can tell. I'm just fixing up some pie files and will update the patch and add a 2.2 patch.

Mysteryem uploaded file 2.2FeaturesFinal.patch (103.1 KiB)

Final patch for 2.2

Mysteryem uploaded file TrunkFeaturesFinal.patch (103.8 KiB)

Final Patch for Trunk

Mysteryem commented

I have tested each of the campaigns using --game CAM_#A

Update includes fixing the ruined hover propulsion, it had infinite hp and moving the trap PIEs 0.1 above the ground to fix collisions with tiles.

Buginator commented

For what it is worth, no real code changes per se are needed for the tabs.
Just change

#define	MAXFEATURES	 80

in hci.h to a bigger number

#define	MAXFEATURES	 200

works with the 2.3 patch.

In fact, I am not sure the other numbers are correct either, since there were 80, and I changed them to 200, do we have more than 200 now ?

Mysteryem uploaded file 2.3unifeatures.patch (127.5 KiB)

Per changed status from new to closed

Per changed resolution from `` to fixed

Buginator changed priority from minor to blocker

Buginator changed status from closed to reopened

Buginator changed resolution from fixed to ``

Buginator changed milestone from 3.0.1 to unspecified

Buginator commented

In f78910162bb224467b49cf3e42e43d9ca41d3156 that breaks campaign games, since page 6 was removed (renamed)

What is the reason for the rename ?

data\base\texpages\page-29-features-arizona.png	page-29-features-arizona.png	.png	Rename	

data\base\texpages\page-31-features-urban.png	page-31-features-urban.png	.png	Rename

AFAIK, this will break all campaign mods (not that we have any that I can recall), and currently breaks campaign transitions from 1 -> 2 and 2->3.

refs #2594

(I know the fix is trivial, but I still want to know the reason for the rename before we fix the wrf files...)

Mysteryem commented

Afaik, warzone just reads up to the page-# part of texpages when looking for which texpage to apply on the model. So they need to be different so that the features don't all use the same texpage.

Buginator commented

Was there any reason for the rename though ? It was page-6-feature-*.png

The game does use the long name now.

As long as the wrf files load up all the textures, then it should be fine...

Buginator changed _comment0 which not transferred by tractive

Buginator changed status from reopened to closed

Buginator changed resolution from `` to fixed

Buginator commented

Fix campaign change level scripts broken in f78910162bb224467b49cf3e42e43d9ca41d3156

Fixes #872
Changeset: eeb031e009788d55794ff42b9f0ce2eef4a1e2c1